Backport Charnock Cap and SinTable to PS45-1 branch#49
Open
ukmo-ccbunney wants to merge 4 commits intoukmo_ps45-1.hotfixesfrom
Open
Backport Charnock Cap and SinTable to PS45-1 branch#49ukmo-ccbunney wants to merge 4 commits intoukmo_ps45-1.hotfixesfrom
ukmo-ccbunney wants to merge 4 commits intoukmo_ps45-1.hotfixesfrom
Conversation
Required backport of st4table feature too (#NOAA-EMC/WW3/1124)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This is a back port of the Charnock Cap PR (NOAA-EMC#1225) to the UKMO PS45-1 branch. This necessarily also includes the explicit stress table calculations PR (NOAA-EMC#1124) as the Charnock cap calculations only work when stresses are explicitly calculated (i.e. not taken from the lookup table).
Testing
This branch will need testing to ensure that: